search

mccolljr / segvec

SegVec data structure for rust. Similar to Vec, but allocates memory in chunks of increasing size.
MIT License
35 stars 5 forks source link

impl `io::Write` for `SegVec<u8>` #40

Closed vxpm closed 10 months ago

vxpm commented 11 months ago

very straightforward implementation of the write trait

mccolljr commented 11 months ago

Thank you for this - even though it's a very simple change, would you mind adding a test?

vxpm commented 11 months ago

sure! i'll change this implementation a bit, however. i think it can be optimized further with something like a extend_from_slice.

vxpm commented 11 months ago

i rebased this to be on top of #41 , not sure if it was a good decision - git is hard

mccolljr commented 11 months ago

Acknowledged - I should have some time later today to look this over

mccolljr commented 10 months ago

Once we finish up the review on #41 I can come back and merge this, but I want to fix up the potential safety issue over there first, then we can rebase this on the master branch and I can push it through :)

mccolljr commented 10 months ago

Now that #41 has been merged, can you rebase this on the master branch?

vxpm commented 10 months ago

done!

mccolljr commented 10 months ago

Thanks, merged!