search

mccoyst / min-game

Automatically exported from code.google.com/p/min-game
MIT License
2 stars 1 forks source link

Reconcile world.TileSize and explore.go:/TileSize #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This shouldn't be defined twice.  I am inclined to use the one defined in th e 
world package since that package also says which images (via Terrain.Name) to 
use for each tile.  Also, otherwise, reading a world would be a clumsy two-step 
process:
   w := world.Read(in)
   w.Pixels = geom.Torus{w.W*TileSize, w.H*TileSize}.

Original issue reported on code.google.com by burns.ethan@gmail.com on 20 Nov 2012 at 9:02

GoogleCodeExporter commented 9 years ago 
Sounds fine to me to use the world one. Although it's reference a lot in 
explore.go, so maybe the const should be changed to a var of the same name and 
set to world's value.

Original comment by Mcco...@gmail.com on 20 Nov 2012 at 9:37

GoogleCodeExporter commented 9 years ago 
Anyone can do this.

Original comment by burns.ethan@gmail.com on 11 Dec 2012 at 6:09

GoogleCodeExporter commented 9 years ago 
There are also TileSizes in some of the XXXgen programs.  These ones can easily 
use world.TileSize.

Original comment by burns.ethan@gmail.com on 11 Dec 2012 at 8:08

GoogleCodeExporter commented 9 years ago 
I'll do this now.

Original comment by burns.ethan@gmail.com on 13 Jan 2013 at 7:38

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 182fc40ea36c.

Original comment by burns.ethan@gmail.com on 13 Jan 2013 at 7:53