mccreery / better-hud

All the information you'll ever need! A Minecraft mod written in Forge.
https://www.curseforge.com/minecraft/mc-mods/better-hud
MIT License
32 stars 11 forks source link

Pickup Count only works on integrated server #93

Closed mccreery closed 4 years ago

mccreery commented 4 years ago

Problem: Since 24cb11a, the Forge event ItemPickupEvent has been used to notify the pickup count of new items. ItemPickupEvent is called on the logical server only. If the client is a slave (connected to a dedicated server), the event is not triggered.

Solution: The ItemPickupEvent handler should send a message to the logical client using the same mechanism as pre- 24cb11a. The message handler should be the one to update the client list.

It should be easy to keep the original message format. Then we can support servers running [,1.4] and [current,].