search

mccrodp / message_private

The Message Private module provides a message type and associated entity reference fields, enabling sending and receiving private messages using The Message Stack.
https://www.drupal.org/project/message_private
3 stars 7 forks source link

Fix access control #34

Closed NewZeal closed 6 years ago

NewZeal commented 6 years ago

Crucial permissions are missing, preventing access for non admin users to their messages. The solution creates new permissions and applies them in the condition that manages access for edit, view and delete.

Oops accidentally included access handler which will be in another pull request.

mccrodp commented 6 years ago

It's all yours now @NewZeal, I'm not working with Drupal anymore. Great that the required fixes are coming in. Nice one! 😄

mccrodp commented 6 years ago

If you can get someone else from the community to help maintain, even better.

mccrodp commented 6 years ago

You have access to merge, right?

NewZeal commented 6 years ago

Can you describe again the process for deploying? I know you wrote it somewhere but it is lost in a thread. If I merge into 8.x-1.x and push to this github repo, then the module is available here. What do I do to have it deploy to the project page on drupal.org?

NewZeal commented 6 years ago

Merged into github repo.

mccrodp commented 6 years ago

Hey. It's just using git and managing a separate remote: https://git-scm.com/docs/git-remote

So, just having both remotes added (you already have origin as GH most likely), then add:

git add remote drupal LINK <- something like this

then

git push 8.x.1.x drupal

NewZeal commented 6 years ago

OK, got it. First time using multiple remotes...