Closed mloskot closed 1 month ago
Attention: Patch coverage is 86.04651%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 95.07%. Comparing base (
34a21a3
) to head (9493ea4
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
httpbin/cmd/cmd.go | 91.42% | 2 Missing and 1 partial :warning: |
httpbin/options.go | 0.00% | 3 Missing :warning: |
@mccutchen
I think I'd prefer a slightly different approach where the environment is resolved at process startup and passed explicitly to
httpbin.New()
via a newhttpbin.WithEnv(env map[string]string)
option func.
This is a very good suggestion indeed. I will update this PR with the process startup approach.
@mccutchen I've refatored and the HTTPBIN_
vars are now collected at the startup. I'll welcome any feedback - I'm available to implement any suggestions you may have.
Pleasure is mine, thanks!
Proposal of implementation of the feature request
114
I've submitted this for an initial round of review. I still have to add more cases to the test and add the endpoint to the index page, but first I'd like to receive feedback if this implementation goes in the right direction.