search

mccutchen / go-httpbin

A reasonably complete and well-tested golang port of httpbin, with zero dependencies outside the go stdlib.
https://httpbingo.org
MIT License
596 stars 124 forks source link

VERSION in Makefile resolved to Git hash instead of tag #190

Open mloskot opened 1 month ago

mloskot commented 1 month ago

The git rev-parse --short HEAD below resolves to Git hash

https://github.com/mccutchen/go-httpbin/blob/34a21a3ef81df5aa42185fcae2e5a608404ac6a0/Makefile#L3-L4

Shouldn't the VERSION be based on Git tag, that is, git describe --tags --abbrev=0?

This makes me wonder, is this VERSION actually used for the image tagging?

Perhaps Docker images are tagged following this instruction?

https://github.com/mccutchen/go-httpbin/blob/34a21a3ef81df5aa42185fcae2e5a608404ac6a0/DEVELOPMENT.md?plain=1#L93-L95

If my understanding is correct and there is room for improvement indeed, I can propose PR.