search

mccxiv / tc

A desktop chat client for Twitch
ISC License
188 stars 17 forks source link

Hotkey tooltips don't show ctrl #404

Closed Bauke closed 6 years ago

Bauke commented 6 years ago

Ctrl + S Ctrl + N

OS: Ubuntu 16.04 Not sure if it's OS specific, I'll try this on Windows 10 later and edit this issue.

Ctrl + S Ctrl + N

OS: Windows 10

Edit: I don't have a Mac so can't test it on there, if anyone does feel free to post the results.

Bauke commented 6 years ago

After #403 where return {restrict: 'E', template, link} was changed to return {restrict: 'E', scope: {}, template, link} this seems to be fixed for the chat tabs (ctrl + n), I guess this is the problem for other tooltips too.

mccxiv commented 6 years ago

Yes, I think the scope bug you fixed in that PR also fixed this. I need to go through all directives and give them a local scope, or better yet convert them to .component() (angular 1.5+)