Inline mod command improvements

mccxiv / tc

A desktop chat client for Twitch

ISC License

188 stars 17 forks source link

Inline mod command improvements #463

Closed mccxiv closed 6 years ago

mccxiv commented 6 years ago

[x] The inline purge button becomes a ban or 24hr button if the user has been timed out
[x] The chat stops scrolling if you hover the buttons, and resumes scrolling once you un-hover
[x] Unrelated but needs fixing: Errors in console when on the Add Channel tab

camalot commented 6 years ago

I may have some time tonight (or this weekend) to take a look at these.

there is already a ban button there. these behave just like the 3 buttons that are in the user-panel. A possible improvement would be to allow configuration of how long to timeout for.

I don't think changing to a ban, if they have been timedout/purged is ideal. There are many times that I have purged a person more than one time, or even timed them out more than once.

mccxiv commented 6 years ago

I'm starting on it now, don't worry (unless you did it already?)

camalot commented 6 years ago

I have not, but can you please clarify the "inline purge becomes a ban"? because there are many cases where I would not want to perma ban, or even 24 hour ban, just because I timed out someone already.

The scroll one, that one is actually a really good feature though. I have accidentally banned the wrong person in active chats because of scrolling.

camalot commented 6 years ago

Another option, would be to allow people to choose the amount of time to timeout, and purge, and if they want to show each of the actions: purge, timeout, ban

here is a mockup I started throwing together in my fork.

I am suggesting something like this, over what is currently in master because the way it is, it does not work for me.

mccxiv commented 6 years ago

I have some time this weekend. The goal is to add this and make a release

mccxiv commented 6 years ago

Version 1 has no setting, but if we get feedback then we can add an on option in the settings menu