search

mcdallas / wallstreet

Real time stock and option data.
MIT License
1.33k stars 201 forks source link

Source='google' option fails #34

Closed josiahlund closed 2 years ago

josiahlund commented 3 years ago

It appears that attempting to call any valid ticker with the source='google' option fails. Line 168 of wallstreet.py is a "catch all" exception that is resulting in a LookupError being thrown even when a valid symbol is passed. Just spending a few minutes trying to find the source on the issue leads me to believe that the response text from line 162 is html rather than something that json.loads() can parse.

mcdallas commented 3 years ago

Yes google finance API has been discontinued for a while now, the old google code needs to be removed.

josiahlund commented 2 years ago

Is there a commit associated with this issue being closed? It seems the issue still exists.

mcdallas commented 2 years ago

Other than google bringing back Google Finance how can this be fixed?

josiahlund commented 2 years ago

I would say removing the non-functioning code from the code base.