search

mcdamo / tab-image-saver

Firefox addon to save images from open tabs
https://addons.mozilla.org/firefox/addon/tab-image-saver/
Mozilla Public License 2.0
39 stars 14 forks source link

Fix filename sanitization (for e.g. Twitter) #84

Closed 54ac closed 1 year ago

54ac commented 1 year ago

Hi, this is a quick fix for the sanitization of newer Twitter filenames (filename?format=jpg) and for properly recognizing their filenames (previous regex removed the entire string if no . was found).

mcdamo commented 1 year ago

Thankyou, this is a nice simple fix.

Resolve the review and I can merge, otherwise close this and I can make the change in master.

54ac commented 1 year ago

Should be fine now, you can merge.

mcdamo commented 1 year ago

Should be fine now, you can merge.

Wrong changes merged? getFilename still showing unwanted changes, while your fix to getFilePart has disappeared.

54ac commented 1 year ago

getFilePart is already fine in 4.3.0, only getFilename remains, but I'm not sure if it's necessary now.