search

mcdelta-project / mcdelta-python

MCDelta client written in Python
GNU General Public License v3.0
3 stars 3 forks source link

Selecting an instance in the menu then trying to install a mod causes glitchy partial instance switching #44

Open Valiec opened 6 years ago

Valiec commented 6 years ago

The issue is that if you have an instance selected (i.e. active) (I'll call it "InstanceA"), and you select another instance (I'll call it "InstanceB") in the menu but not actually select it with the select instance button, then install a mod, the mod list shown changes to match InstanceB, but the compatibility check still seems to use InstanceA.

There are probably other issues regarding this, but I haven't tested it further.

williambl commented 6 years ago

Perhaps we should do away with the select instance button and just have it change the instance when you select it in the dropdown? It seems more intuitive - the instance displayed is the instance selected.

Valiec commented 6 years ago

I've thought about that, but it would cause troubles for removing instances, since you currently cannot remove the current active instance.

A solution would be to allow you to remove the current active instance, but not the instance set as default, which will then be selected when the current instance is removed.