search

mcdelta-project / mcdelta-python

MCDelta client written in Python
GNU General Public License v3.0
3 stars 3 forks source link

New syntax #46

Closed williambl closed 6 years ago

williambl commented 6 years ago

This branch has accomplished its goal of getting the new syntax to work, so I say we merge it.

Valiec commented 6 years ago

I was taking a look at this, and I think should not be merged yet. It produces an UnboundLocalError when you try to install a Forge mod.

I've fixed it on my local copy, but I'm also working on eliminating unwanted console output (e.g. "Enter mod folder location for instance default (absolute path): Mod folder for default path DeltaMC", especially the bold part) when creating an instance.

williambl commented 6 years ago

Alright. I agree.

Valiec commented 6 years ago

I pushed the UnboundLocalError fix.

williambl commented 6 years ago

Okay, now that those problems are fixed, would you say it's mergeable?

Valiec commented 6 years ago

I think it's ready to merge.

williambl commented 6 years ago

Okay, I'm merging this and deltamc-archive/#9 at the same time.