search

mcdelta-project / mcdelta-python

MCDelta client written in Python
GNU General Public License v3.0
3 stars 3 forks source link

'output' arg in many functions #52

Open williambl opened 5 years ago

williambl commented 5 years ago

Many functions have an 'output' argument which, if true, prints the output as well as returning it. I feel like this just clutters the code a bit, and doesn't really fit with the idea that a function should do one thing only.

This issue is for discussion of whether or not they should be removed, and is the first in a few issues I'm going to make regarding the problem of 'code smell'.

Valiec commented 5 years ago

I'm going to investigate which functions are doing this and how important it really is (i.e. how much it is making other code cleaner).

Valiec commented 5 years ago

They aren't that important, I'm splitting off the print output thing as its own function (and I only found 4 functions that do this in delta_util.py, will look in other files after I fix these).