mcdougallab / matlabneuroninterface

Interface for connecting NEURON and MATLAB
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Load MOD file example; works right away! #59

Closed edovanveen closed 1 year ago

edovanveen commented 1 year ago

Closes #10

ramcdougal commented 1 year ago

Point of clarification: it's good that this works and that we have an example, but this is not a "point process"... a point process in NEURON occurs at a point (we call h.mod a density mechanism because it's spread out over a region at a certain density).

Here's a Point Process defined in a mod file: http://modeldb.science/getModelFile?model=2730&file=bulbNet/nmdanet.mod

In particular that defines a thing called NMDA, but one does not insert_mechanism("NMDA") (that should be an error)... instead one treats this like an IClamp, and defines, say syn = n.NMDA(axon(0.5)). If it's working, then you should be able to read and set syn.Alpha (default value is 0.072), syn.Beta (default is 0.0066), and syn.e (default is 45).

edovanveen commented 1 year ago

I think I processed all your comments, but I had to rebase this branch onto branch 48-iterating-over-... in order for the point process example to work as intended (with syn = n.NMDA(axon(0.5))), so ideally that PR is merged first.

ramcdougal commented 1 year ago

Thanks. Sounds good. I do have one comment/request on #49 that I just added, but otherwise that looks good... once that's done, is this ready to merge too?

edovanveen commented 1 year ago

@ramcdougal ready for review/merge