search

mcekovic / tennis-crystal-ball

Ultimate Tennis Statistics and Tennis Crystal Ball - Tennis Big Data Analysis and Prediction
Apache License 2.0
256 stars 36 forks source link

Top Performers View Filter Issue #379

Closed SrijanKhare closed 1 year ago

SrijanKhare commented 1 year ago

In the Top Performers view (https://www.ultimatetennisstatistics.com/topPerformers), I have put the following filters

With those filters, we can see that the view shows Federer has 28 total matches, however, when you click on the number it brings up Federer's player view with the same filters. The issue is that with the same filters the player view shows 21 total matches while the Top Performers view shows 28 total matches.

Seems like the issue is rooted in either of these two places: https://github.com/mcekovic/tennis-crystal-ball/blob/master/tennis-stats/src/main/java/org/strangeforest/tcb/stats/service/TopPerformersView.java or https://github.com/mcekovic/tennis-crystal-ball/blob/b4b602e0eeea8365839fee7500d8b1248f186be0/tennis-stats/src/main/resources/templates/topPerformers.html

Maybe the category is not being set correctly?

mcekovic commented 1 year ago

When Category is 'Tie Breaks', in Top Performers Played columns is number of Tie Breaks, not number of matches. MC

On Fri, Dec 16, 2022 at 11:35 PM Srijan Khare @.***> wrote:

In the Top Performers view ( https://www.ultimatetennisstatistics.com/topPerformers), I have put the following filters

  • Tournament Level: Big
  • Opponent: Elo > 2400
  • Min Entries: 15
  • Category: Tie-Breaks

With those filters, we can see that the view shows Federer has 28 total matches, however, when you click on the number it brings up Federer's player view with the same filters. The issue is that with the same filters the player view shows 21 total matches while the Top Performers view shows 28 total matches.

Seems like the issue is rooted in either of these two places: https://github.com/mcekovic/tennis-crystal-ball/blob/master/tennis-stats/src/main/java/org/strangeforest/tcb/stats/service/TopPerformersView.java or

https://github.com/mcekovic/tennis-crystal-ball/blob/b4b602e0eeea8365839fee7500d8b1248f186be0/tennis-stats/src/main/resources/templates/topPerformers.html

Maybe the category is not being set correctly?

— Reply to this email directly, view it on GitHub https://github.com/mcekovic/tennis-crystal-ball/issues/379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPUVTHM4W4FNPVDNJXYEW3WNTVCXANCNFSM6AAAAAATBSD2CQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SrijanKhare commented 1 year ago

ah okay, makes sense!