search

mcespedes99 / sEEGPrep

1 stars 0 forks source link

Notch column is optional in the BIDS spec, currently the extra validation fails if it isn't present #16

Open akhanf opened 5 months ago

akhanf commented 5 months ago

Here is the line:

https://github.com/mcespedes99/sEEGPrep/blob/8712f12013aa149c2e629139d3b6adbf6fe61d9f/seegprep/workflow/scripts/ext_val.py#L53

and the corresponding link in the BIDS spec: https://bids-specification.readthedocs.io/en/stable/modality-specific-files/intracranial-electroencephalography.html#channels-description-_channelstsv

I wonder if this extra validation is necessary? Does the bids validator not check column names? Or is this to allow running on BIDS datasets that are not quite validated?

mcespedes99 commented 2 months ago

Updated in commit https://github.com/mcespedes99/sEEGPrep/commit/60009b5e506358edf304dd946b91c5d8858c327e Missing sanity check