Build with PEP 517, move project metadata to setup.cfg

mcfletch / pyopengl

Repository for the PyOpenGL Project

Other

314 stars 97 forks source link

Build with PEP 517, move project metadata to setup.cfg #85

Closed EpicWink closed 1 year ago

EpicWink commented 2 years ago

This differs from #84 by not specifying project configuration in pyproject.toml. This means older Python version support is not dropped.

Specify build backend in pyproject.toml (PEP 518)
Remove unused 'ctypes' dependency
Remove empty accelerate requirements file
Remove '..' from accelerate build include-dirs
Install package with pip in AppVeyor
Build package with PyPA's Build in AppVeyor
Skip explicit build dependency install in AppVeyor
Upgrade pip if found in AppVeyor

ChrisBarker-NOAA commented 2 years ago

I think this is a better option than #84.Not because of old Python versions, but because I think setuptools is the the way to go for C extensions -- pyopengl-accelarate may require that.

Have you tested with accelerate as well?

If we're going to do wheels, it would be very nice to have that.

EpicWink commented 2 years ago

I think setuptools is the the way to go for C extensions

Both #84 and this PR haven't changed the build-backend from setuptools. They just use different (static) files to declare project metadata (and use PEP 517 to declare setuptools as the backend, instead of legacy implicit).

Have you tested with accelerate as well?

As you can see in this PR's (and #84's) checks, AppVeyor has successfully built the wheels for both projects (including accelerate), just like in the main branch

ChrisBarker-NOAA commented 2 years ago

Wonderful -- then I personally vote for #84 -- no need to support Python versions that far back.

Thanks for putting this together.