search

mcfletch / simpleparse

SimpleParse parser generator using mxTextTools (launchpad mirror)
Other
10 stars 12 forks source link

Support for creating binary (bytes) parsers (Python 3 only) #15

Open hernot opened 2 years ago

hernot commented 2 years ago

This is my suggestion for resolving issue #13. The precondition is that python 2 support officially has ended as proposed solution is python3 only. It removes python 2 from tox.ini and appveyor.yml.

Awaiting your review and appreciating any input also regarding any suggestions on how to deal with commons which are currently str (utf8) only and additional tests which i should add, amend or improve

If necessary i'm fine to rebase to updated upstream head whenever you will merge an earlier pull request.

Apart from the purpose of this pull request and the small advice requested for in issue #14 may i suggest to enforce that tests are run in order of dependencies between modules? Currently some of the feature and issue tests are run before the unit tests for simpleparse/generator.py, simpleparse.simpleparsegrammar.py and simpleparse/commons modules which are essential for proper operation of simple parse and have dependencies in the mentioned order. (The best of all worse solutions i have found in this context so far is prefixing test files by test_NN_´ instead of plaintest_` )

Would you be interested in a tox based github action for CI testing on linux and mac in addition to appveyor or even in replacement on windows too?

hernot commented 2 years ago

@mcfletch how likely is it that you find the next weeks mont some time to review and decide how to continue on this.

No hurry it is just that i came across your or somebody elses thoughts about adding support for mmap objects. I might have an idea/suggestion on how to add support for parsing any contigous blob of byte and want to give ti a try. I do thereby not want to mix things.

hernot commented 2 years ago

Should read my own issue #9. According to my own finding precondition for this pr met.