search

mcgeer / WastedBankSpace

Runelite Plugin for wasted bank space
BSD 2-Clause "Simplified" License
5 stars 15 forks source link

Add ability to not flag items #14 #63

Closed BramManuel closed 1 month ago

BramManuel commented 3 months ago

Closes #14

Think this makes the plugin even better, for example for seeds i use daily, i can add them to the non flagged list and the rest i can brainlessly dump into the seed vault.

I hope you like it! please give feedback where needed!

mcgeer commented 3 months ago

Busy this weekend but will review within the week. I hope it was fun to write, people have asked for this feature a few times on disc. Lemme know if you want your rsn or GitHub added to the authors list :)

BramManuel commented 3 months ago

Take your time man! It was, never did something with Java. My Github please :)

Just added another commit, did a refactor to remove the redundant item mapping.

BramManuel commented 3 months ago

Can you take a look at this PR. Because is want to use some logic in PR #64 Thanks!

mcgeer commented 3 months ago

Sure but what specifically do you want me to comment on that I did not already?

BramManuel commented 3 months ago

Sure but what specifically do you want me to comment on that I did not already?

Hmm, I dont see any comments on this PR..

mcgeer commented 3 months ago

Forgive me, don't use git hub in enterprise and just learned I had to submit the review, was in draft.

BramManuel commented 2 months ago

Can you take a look at my comments? @mcgeer

mcgeer commented 2 months ago

Was in Florida but am home now, if you want me to check something in the short term add me on Discord: evilrail

BramManuel commented 2 months ago

Was in Florida but am home now, if you want me to check something in the short term add me on Discord: evilrail

Nice had a nice trip? Added you, can you merge this pr?

mcgeer commented 2 months ago

Merged into https://github.com/mcgeer/WastedBankSpace/tree/blacklist Includes #64 changes.

Do not want to merge to master till it is ready.

I tested with Holy Wraps and Holy wraps. Case sensitive is not ideal here. A string comparator with ignore case would be good likely.

I also just noticed hovering over configs does not show the description. unsure what broke this if you want to investigate. Was late when I started merging so may be my bad.

I still plan to play around with using ID instead of name behind the scenes but that will wait.

mcgeer commented 1 month ago

Why was this closed?