#WIP First setup of Data Organization, and covert keyring tacklebox and leprechaun #16

mcgeer / WastedBankSpace

Runelite Plugin for wasted bank space

BSD 2-Clause "Simplified" License

5 stars 12 forks source link

#WIP First setup of Data Organization, and covert keyring tacklebox and leprechaun #16 #64

Open BramManuel opened 1 week ago

BramManuel commented 1 week ago

closes #16

This is a draft PR. I want to check if you agree with this solution? before i make allot of new enums for all the storage locations.

mcgeer commented 4 days ago

Nice abstraction, I think this is a better impl. The single file instantiation of all items in StorableItem was kinda clunky.

mcgeer commented 4 days ago

https://regexr.com/825cd

Whipped this together to transform my data instantiation to yours. Go to list, you need to modify the main area by adding a space or something if the query takes to long and it will then load.

mcgeer commented 4 days ago

BramManuel commented 4 days ago

I did the same with find and replace in IntelliJ: , (?<=\(\s*ItemID\.\w+,\s*)\w+\.\w+(?=\s*\))

Will be working on this again on friday evening!