Rename Diagnostic

[mcgibbon]

Some people have brought up and we have also found that it's a little confusing to talk about Diagnostics producing diagnostics, especially when Prognostics produce diagnostics along with every other component. I'm not sure what a better name is, however, and we've been pondering this for some time. It may be that we need to rename multiple components so they all have a similar style of naming.

Some possibilities:

• We could rename multiple components so that we have DiagnosticScheme, PrognosticScheme, ImplicitScheme or similarly for DiagnosticComponent etc.
• Adjustment is good to describe components that modify existing inputs, but doesn't apply to many diagnostic schemes.
• That's all I've got for now.

[JoyMonteiro]

I don't understand what Scheme means here. Are you suggesting we extend the base class names by adding suffixes (and create subclasses) or create a large number of new classes?

I think the confusion arises from the fact that there exists no model currently with a set of classes like sympl does. diagnostics are part of the output, and no one cares how they are generated. I'm hesitant to accommodate a change which takes sympl backwards in time to make it correspond well with current model structure/usage.

[mcgibbon]

I mean extend the base class names, without creating any subclasses or new classes. Just changing the names of the base classes.

It's confusing to have the word "diagnostic" refer to either a Diagnostic component or a diagnostic quantity. This is confusing regardless of the current modeling paradigm.

[JoyMonteiro]

In that case, I would prefer adding the Component suffix -- makes it very clear what it is.

[mcgibbon]

I agree that this appears to be the cleanest option at the moment. I'll do this for 0.4.0 so we can use this language in the paper, along with the Implicit -> Stepper change.

[mcgibbon]

Final language change is Diagnostic --> DiagnosticComponent Prognostic --> TendencyComponent Implicit --> Stepper TimeStepper --> TendencyStepper

Additionally, TimeStepper will be a subclass of Stepper.

[JoyMonteiro]

Ack. Close this issue now?

[mcgibbon]

I'll close this and several other issues when we merge their pull requests.

[mcgibbon]

Fixed by #26