search

mcgibbon / sympl

A toolkit for building planetary/Earth system models in Python
http://sympl.readthedocs.io
Other
50 stars 14 forks source link

Rename Implicit to (Time)Stepper, TimeStepper to PrognosticStepper #34

Closed mcgibbon closed 6 years ago

mcgibbon commented 6 years ago

I was thinking about how currently the API of TimeStepper is such that it implements Implicit, and that really TimeStepper should be a subclass of Implicit. I propose we do so, and rename the objects to make this make more sense. Implicit could be called Stepper or TimeStepper, and TimeStepper could be called PrognosticStepper (since it steps Prognostic objects).

JoyMonteiro commented 6 years ago

Actually, as I was revising the manuscript I realised this exact thing. I think this makes sense, and will remove some of the ambiguity that people encounter when I talk about the class names.

I support Implicit being called Stepper. PrognosticStepper also sounds fine.

mcgibbon commented 6 years ago

Fixed while fixing #32