search

mcgibbon / sympl

A toolkit for building planetary/Earth system models in Python
http://sympl.readthedocs.io
Other
48 stars 14 forks source link

UpdateFrequencyWrapper bug #41

Open JoyMonteiro opened 6 years ago

JoyMonteiro commented 6 years ago

When UFW wraps a TendencyComponent, it should be considered an instance of TendencyComponent. However, sympl currently considers it both a TendencyComponent and ImplicitTendencyComponent, which ends up calling a TendencyComponent with a timestep, causing it to error.

mcgibbon commented 6 years ago

I added a fix to UFW that will retry without passing along the timestep if it gets a TypeError, but the underlying problem that UpdateFrequencyWrapper is considered an ImplicitTendencyComponent regardless of whether it wraps one currently remains.