search

mcgibbon / sympl

A toolkit for building planetary/Earth system models in Python
http://sympl.readthedocs.io
Other
50 stars 14 forks source link

Fix issue with numpy indexing #49

Closed JoyMonteiro closed 1 year ago

JoyMonteiro commented 1 year ago

This PR fixes a long-standing issue which prevented sympl tracer code from working with new versions of numpy.

If you think this is fine, I would like to immediately release a new version so that we can also update GFSDynamicalCore

JoyMonteiro commented 1 year ago

I have made the required changes. All tests are passing and I fixed a number of deprecation warnings which would have likely broken with future releases of numpy and xarray.

JoyMonteiro commented 1 year ago

Yes, the tests all pass. Could you please make the release? we should automate this in the coming days.

On Sun, Feb 5, 2023 at 2:06 AM Jeremy McGibbon @.***> wrote:

@.**** approved this pull request.

The changes look fine to me, assuming you've run the tests and that you plan to release on pypi right after this. If I need to make the release let me know.

— Reply to this email directly, view it on GitHub https://github.com/mcgibbon/sympl/pull/49#pullrequestreview-1284113218, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXWKPIWCNUYP6EX6S6MFTLWV24U7ANCNFSM6AAAAAAUQDVRYI . You are receiving this because you authored the thread.Message ID: @.***>

-- The best ruler, when he finishes his tasks and completes his affairs, the people say “It all happened naturally”

                                     - Te Tao Ch'ing
mcgibbon commented 1 year ago

I see you have released. Thanks!

JoyMonteiro commented 1 year ago

Yes, realised you had added me as a maintainer!

On Thu, Feb 9, 2023, 01:15 Jeremy McGibbon @.***> wrote:

I see you have released. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/mcgibbon/sympl/pull/49#issuecomment-1423152567, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXWKPMDVK7RXTLOQQ5KNFLWWPZWZANCNFSM6AAAAAAUQDVRYI . You are receiving this because you modified the open/close state.Message ID: @.***>