search

mcgill-robotics / AUV-2025

Software running on Douglas AUV for 2024 RoboSub competition
GNU General Public License v3.0
22 stars 3 forks source link

build docker images with buildx #614

Closed MrMondrian closed 2 months ago

MrMondrian commented 2 months ago

The images currently hosted on docker hub are built only for amd64, but they need to be rebuilt for amd64 AND arm64 to accommodate mac users when they return. Only need to do this for base sim and poolside (in that order).

someone must've forgotten to use buildx at comp then pushed and since we all had amd64 machines no one noticed

instructions can be found here

majdkhalife commented 2 months ago

Its done. I can write out steps for people and add it in the wiki in case this would happen again? What do you think

MrMondrian commented 2 months ago

Yes I agree, its a really easy mistake to make. Most peoples instincts is to either run docker build or docker compose build but neither invoke buildx

MrMondrian commented 2 months ago

It might be possible to get docker compose build to cross compile by using the platform option https://github.com/compose-spec/compose-spec/blob/main/spec.md#platform and passing --builder as a command line arguments to docker compose build but not sure if this is possible or really all that useful