mcgillij / amdfan

Updated AMD Fan control utility forked from amdgpu-fan and updated.
https://mcgillij.dev/pages/amdfan.html
GNU General Public License v2.0
33 stars 8 forks source link

fixes boot order for systemd unit #22

Closed GIJack closed 1 year ago

GIJack commented 1 year ago

On some systems, such as using the -hardened kernel, and with Gnome Display Manager, the service will fail if it runs before the GDM.

So we make it go last, and it works.

motolav commented 1 year ago

This PR causes the service to not start on a fresh install of arch running KDE, final.target is for shutdown so that's probably why its not starting.

final.target

A special target unit that is used during the shutdown logic and may be used to pull in late services after all normal services are already terminated and all mounts unmounted.

mcgillij commented 1 year ago

final.target

I'm on Arch, as well, no KDE though (I just use i3), and the final.target seems to be working on mine.

Can you alter your target in : /etc/systemd/system/multi-user.target.wants/amdfan.service

and let me know which one works for you in there?

motolav commented 1 year ago

I changed to WantedBy=multi-user.target to get it to work but I just tried WantedBy=final.target again and it's working now after rebooting a few times so I have no idea what was going on but it seemed like systemd wasn't even trying to start the service at all when set to enabled with WantedBy=final.target