search

mcginty / snow

A Rust implementation of the Noise Protocol Framework
Apache License 2.0
883 stars 120 forks source link

Consider `aead::Aead` as an alternative to (or building block for) `Cipher` #72

Open tarcieri opened 4 years ago

tarcieri commented 4 years ago

The aead crate provides abstractions for AEAD algorithms (including no_std-friendly ones) with several implementations including adapters for the AEAD algorithms in ring.

Aside from the rekey method, it seems like it's close to a drop-in replacement for the existing Cipher trait.

mcginty commented 4 years ago

Thanks for the issue @tarcieri!

These types should hardly be touched except for the rare cases where people need to implement their own providers of crypto algorithms not provided by snow itself, so I'm not sure if I can currently justify the extra dependency in my head, especially if only Cipher gets this treatment, and we don't also start relying on RngCore to replace Random, etc.

fogti commented 4 years ago

Currently, snow already depends on crates which depend on aead, so this wouldn't really change the amount of crates pulled in.

tarcieri commented 4 years ago

There is one problem with using the aead crate's traits for Snow's purposes right now: they aren't object safe, but easily could be with some small changes.

fogti commented 4 years ago

that specific issue with aead is fixed now.