dmcglinn
commented
6 years ago Thanks for this @AshleyWoods, congrats on your first pull request!! Nice job. Here is what I notice:
- [x] please commit and push the csv file so that it is included on the repo
- [x] please code a bit more defensively. What I mean about this is to code so that your code is less likely to break or contain a bug. For example, when referencing a column of a data frame it is usually better to reference the column name rather than the column number. This is because column order sometimes changes and then you don't want the dependent code to bug or break. Also this makes the code more readable.
- [x] I love that you are using functions in your code, but in this specific modification it may actually make it harder to see what's going on. In your csv file were you have the 1's and 0's associated with each field you can simply cut to a subset of column names doing something like
fields = my_csv$fields[my_csv$min_set == 1] - [x] your coding style is coming along but try not to mix camelCase and snake_case. I recommend just picking snake_case and sticking with it. This makes code more readable and easier for others to build off. A popular naming convention amongst R developers is to use dots in names "my.var" I recommend against this because like python, R has an S3 object oriented naming system that uses dots to denote attributes of an object.
After you have made these changes locally and committed them on this branch you can push them and they will be added automatically to this PR.
AshleyWoods
Puts the sorting of columns and options into a separate file so that it is easier to expand upon or alter.