search

mcgoo / cargo-vcpkg

Get external dependencies in one step by specifying vcpkg details in Cargo.toml
Apache License 2.0
39 stars 6 forks source link

Add support for overlay triplets #13

Closed pkgw closed 2 years ago

pkgw commented 2 years ago

This helps with #4.

I also silenced a warning as a conservative way to make it go away — it refers to a field in a Serde struct so if we just get rid of it, that could conceivably break existing files.

Finally I also grouped the return values from the process_metadata() function into a struct since the tuple was getting unwieldy.

pkgw commented 2 years ago

@waych Hmm, should there be CI running with the GitHub Workflows here?

pkgw commented 2 years ago

I should mention that the only ways to test the functionality that I could think of were either (1) trivial "does Serde work?" or (2) would require a whole new stack to actually run vcpkg. So I didn't add any tests :-/

waych commented 2 years ago

This looks pretty slick.

The Actions were all disabled. I was able to re-enable them, but I think it will require a change to this PR to trigger them here. I just kicked them off on the master branch; I have no idea yet if they still pass. 🤞

pkgw commented 2 years ago

Unsurprisingly there are some CI errors to fix up here, but it looks like they're pretty superficial issues with setting up Windows compilers. Hopefully easy to fix. @waych @kornelski, feel free to push fixes to this branch if you have a moment to dig in — I won't be able to follow this up for a little while.

waych commented 2 years ago

Main branch is now green.

pkgw commented 2 years ago

Thanks! I've merged it in here to verify that the CI clears.

pkgw commented 2 years ago

Thanks! Would you mind looking into whether the release checklist still works?