search

mcgoo / vcpkg-rs

Build library for finding native libraries in vcpkg for Rust - Windows (msvc), Linux and macOS
https://docs.rs/vcpkg
Apache License 2.0
108 stars 22 forks source link

Stage a crates-io index that doesn't have rand 0.8.0 #29

Closed waych closed 3 years ago

waych commented 3 years ago

This PR tries to stage a crates-io mirror in the rust 1.10 test where the index is rewound to a point where rand 0.8.0 doesn't exist, as these entries confuse the old index resolution handling in 1.10.

Closes #28

mcgoo commented 3 years ago

Hi @waych, @pkgw. I'm very sick now and I will not be able to work on this anymore.

The 1.10 Rust version used to be required by openssl 0.9 I think. It is probably fine for use a newer version (Rust 1.24.1?) since openssl 0.10 is now current. Feel free to decide how you want on that.

(As an aside, the crates.io/cargo-vcpkg tool is still being released from this mcgoo/vcpkg-rs tree not mcgoo/cargo-vcpkg.)

Thanks for your help on the way through this. I have enjoyed it on the way.

Remind me how to add you to merging on crates.io and github and I'll get that done as soon as I can.

Jim

waych commented 3 years ago

Hey @mcgoo, Sorry to hear about your health :( Whatever the case I hope things begin looking up for you.

I don't quite follow the openssl dependency you describe. Are you suggesting that there are users with downversions of tools+crates that are stuck on older rust because they were using openssl crate 0.9 and haven't yet made the step forward? I'm not sure I understand what makes that package special. I poked around it openssl-sys build and see that it is using vcpkg, but only on Windows.

In either case, it feels like the right thing to do is to continue to support the vcpkg crate being used by older versions. I just managed to get this one to pass at rust 1.12 using the crates-io rewind so perhaps its best to stay with that version conservatively while we can.

I see you started peeling the crates apart into cargo-vcpkg. Will look at what you did there, it seems at first glance that it would be easier if features of cargo could be probed by cargo-vcpkg, but understand if that isn't possible.

Re: crates.io, I haven't yet pushed crates there before, but can take over for you if you are done taking care of this project yourself. I just added my github there in case you looked and didn't find it earlier.

pkgw commented 3 years ago

I'm very sorry to hear that as well — I hope that things take a turn for the better.

My username is on crates.io is also pkgw (I think that's true by definition since crates.io login is using GitHub). If you sign in there and go to your Dashboard, for each of your crates you can go to its Settings tab and add me as an owner. I can add @waych later if you run into any problems adding them now.

I see that you've added me here on GitHub already — thanks.

waych commented 3 years ago

I think I understand the openssl aspect better now in terms of "a reasonable base" needs to be established in downversion support and "This package drafts openssl's support window" is a good base that reasonable people should already be following.