search

mcguffin / acf-openstreetmap-field

WordPress ACF Field for OpenStreetMap
https://wordpress.org/plugins/acf-openstreetmap-field/
GNU General Public License v3.0
107 stars 21 forks source link

Some translations gets wrongly escaped #59

Closed jooola closed 3 years ago

jooola commented 3 years ago

Hello ! I have french translations on my WP site, and the Search... placeholder get translated into : image

I'm not sure where the translation comes from, but something is odd here or in the translations files. Maybe this should not be escaped on this side ?

Thanks for this tool !

mcguffin commented 3 years ago

Salu, the French Translation comes from translate.wordpress.org, where btpub thankfully translated my plugin.

As you can see, he didn't use the unicode char … like in the original but the corresponding HTML entity …. IMHO that's something he should fix.

Escaping strings is always a good thing for security. PO files can be misused an attack vector for code injection.