search

mcguffin / acf-quickedit-fields

WordPress Plugin implementing Column Displaying, QuickEdit and BulkEdit for Advanced Custom Fields (ACF)
https://wordpress.org/plugins/acf-quickedit-fields/
GNU General Public License v3.0
359 stars 49 forks source link

Doesn't recognise ACF pro when licensed as a bundle within another plugin. #146

Open damienlee77 opened 1 year ago

damienlee77 commented 1 year ago

I have a copy of ACF Pro which was included under license with another plugin (namely CustomPageTemplate.com). This plugin doesn't recognize that ACF Pro exists, though other ACF-dependent software does.

damienlee77 commented 1 year ago
image
mcguffin commented 1 year ago

Hi, Unfortunately I don't can not reproduce this – I don't have the license for the other plugin. You're welcome to do some investigation on your own and come back with whatever you found.

The ACF version check starts after_setup_theme … https://github.com/mcguffin/acf-quickedit-fields/blob/76f90572969c8f4bae1795634846262f075f230e/include/ACFQuickEdit/Admin/Admin.php#L79

… and test for the acf() function existence and version: https://github.com/mcguffin/acf-quickedit-fields/blob/76f90572969c8f4bae1795634846262f075f230e/include/ACFQuickEdit/Admin/Admin.php#L116-L121

Maybe just the hook needs to run a little later (20 or so)...