Closed LasaiBarrenada closed 1 year ago
Hey @LasaiBarrenada, thanks for this - PROBAST is a tool I have wanted to include in robvis
for a while (see Issue #6 from 2019!), so thanks for encouraging me to finally get to it!
The best practice way to contribute is via a Pull Request/PR (see intro guide here) - it makes it easier for me to review your proposed additions and ensures that you get credit for the code you have written.
If you'd like to open a PR, I'd be very happy to review/support it!
Some responses to your comments
I think that having an argument to change the angle of the y facet could be interesting otherwhise the study names cannot be displayed if they are a lot of studies
The study labels being vertically orientated is a known issue, and a solution is available via #81
an additional argument to let users control the size of the y axis (size_text)
I have intentionally not included this functionality, in favour of allowing users to perform post-hoc adjustments to the image using ggplot2
, e.g.:
robvis::rob_traffic_light(data_rob2,
tool = "ROB2") +
ggplot2::theme(strip.text.x = ggplot2::element_text(size = 20))
Thanks for the answer Luke, I was not aware that the plot allowed post hoc adjustments. When I have time I will open an issue.
I adapted your rob_traffic_light() function for the Prediction model study Risk Of Bias Assessment Tool (PROBAST). I think this could be useful for other users conducting systematic reviews of prediction models. The code is basically the same but I added an additional argument to let users control the size of the y axis (size_text) and I changed the display of facets in y to horizontal. I think that having an argument to change the angle of the y facet could be interesting otherwhise the study names cannot be displayed if they are a lot of studies. I think that this could be extended to the other functions in the package but I have not done it.
I am not familiar with GitHub collaboration or how issues work so I paste here the code. Let me know if there is a more convenient way for contributing.