search

mcguinlu / robvis

A package to quickly visualise risk-of-bias assessment results
https://mcguinlu.github.io/robvis/
Other
58 stars 22 forks source link

add psize as argument #21

Closed vanAmsterdam closed 5 years ago

vanAmsterdam commented 5 years ago

add argument to easily change size

mcguinlu commented 5 years ago

Hi there,

Thanks for your PR!

I'm not going to pull it in, mainly because (as per #22) there are few things that will need to be implemented simultaneously for this to work best.

Just out of interest, your proposed changes didn't pass the R CMD checks. I reckon it is because you forgot to update the documentation (running devtools::document() or hitting Crtl/Cmd + Shift + D in RStudio should do the trick) after you made the change.

Thanks again for highlighting the lack of a psize argument as something that needs an urgent fix, and please feel free to propose any further changes you think will improve the package!

vanAmsterdam commented 5 years ago

ok thanks for the reply you're absolutely right, i didn't rebuild the docs. been a while since building an R-package

best, Wouter

On Wed, Jun 19, 2019 at 12:17 PM Luke McGuinness notifications@github.com wrote:

Hi there,

Thanks for your PR!

I'm not going to pull it in, mainly because (as per #22 https://github.com/mcguinlu/robvis/issues/22) there are few things that will need to be implemented simultaneously for this to work best.

Just out of interest, your proposed changes didn't pass the R CMD checks. I reckon it is because you forgot to update the documentation (running devtools::document() or hitting Crtl/Cmd + Shift + D in RStudio should do the trick) after you made the change.

Thanks again for highlighting the lack of a psize argument as something that needs an urgent fix, and please feel free to propose any further changes you think will improve the package!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mcguinlu/robvis/pull/21?email_source=notifications&email_token=ADAHBBS3A2VUB2HQLY4Y24DP3JLYRA5CNFSM4HX2T4IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCMOKY#issuecomment-503629611, or mute the thread https://github.com/notifications/unsubscribe-auth/ADAHBBW2IXSNLEPSQZYBVNTP3JLYRANCNFSM4HX2T4IA .