search

mcguinlu / robvis

A package to quickly visualise risk-of-bias assessment results
https://mcguinlu.github.io/robvis/
Other
58 stars 22 forks source link

y_title argument not changing axis label in "Generic" template #97

Closed mcguinlu closed 3 years ago

mcguinlu commented 4 years ago

As noticed when creating the image for Issue #96, the y_title argument for the "Generic" template does not seem to actually change the title of this axis from "Study" (to "Test2" in the example below). 

rob_traffic_light(
  data_rob2,
  "Generic",
  psize = 10,
  x_title = "Test",
  y_title = "Test2",
  judgement_title = "Test3",
  judgement_labels = c("1", "2", "3", "4", "5", "6")
)

Rplot

This is because, at present, the title of this axis is still hardcoded (see this line) - this needs to be changed so that the value passed to the y_title argument is used.

AJFOWLER commented 4 years ago

Hi Luke, I looked at fixing this with my last PR but reckon that we could actually put a huge amount of the traffic light plot generation into a single function that is then called by each tool as required, and implement this? Happy to look into doing this, but not sure if overlaps with any ongoing plans you have!

mcguinlu commented 3 years ago

This specific problem has been solved, but a larger refactoring of the plotting code is on the cards.