search

mchakravarty / ProjectNavigator

SwiftUI project navigation view for macOS and iOS
Apache License 2.0
24 stars 2 forks source link

Compatibility with iOS 18 #26

Open Cubik65536 opened 1 month ago

Cubik65536 commented 1 month ago

Hi,

First of all, thanks for this project.

I'm also experimenting this with iOS 18, however I found out some problems while tinkering with iOS 18 simulator:

  1. The file and directory changes are not saved. (This is not #27 because nothing was saved under iOS 18).
  2. The toolbar/navigation bar are broken (the image shown below is the demo in this repo).

iOS 17:

CleanShot 2024-08-05 at 22 47 29

iOS 18:

CleanShot 2024-08-05 at 22 47 04

Please do consider providing a fix or provide some work-around.

Best regards,

mchakravarty commented 1 month ago

Thanks for reporting this. I haven't tried using the iOS 18 beta so far, but given that we already had a few betas, I agree, it is time to give it a shot. I'll let you know what I find.

Cubik65536 commented 1 month ago

Thanks for reporting this. I haven't tried using the iOS 18 beta so far, but given that we already had a few betas, I agree, it is time to give it a shot. I'll let you know what I find.

@mchakravarty

Thanks! I (sort of) solved the second UI issue by having my own toolbar setup, I will share it to you later when I've completed it.

Cubik65536 commented 1 month ago

Some update on this.

I found no options for iOS 18 to hide the document toolbar (i.e.: the return button and the "rename" text field).

My workaround is to keep it while hiding all the toolbar of the NavigationSplitView and use another added button to control what's shown on the NavigationSplitView.

I will make a PR for this later.

Cubik65536 commented 1 month ago

Some update on this.

I found no options for iOS 18 to hide the document toolbar (i.e.: the return button and the "rename" text field).

My workaround is to keep it while hiding all the toolbar of the NavigationSplitView and use another added button to control what's shown on the NavigationSplitView.

I will make a PR for this later.

Another problem is that the name of the root directory in the navigator won't change if the project "file" is renamed via the Apple Document toolbar. One of the solutions I can think of is just not show the root directory as a folder and directly show all the sub-folders and files.