search

mchalupa / dg

[LLVM Static Slicer] Various program analyses, construction of dependence graphs and program slicing of LLVM bitcode.
MIT License
481 stars 135 forks source link

Add cmd-args test and port everything to `llvm::cl` #375

Closed lzaoral closed 2 years ago

lzaoral commented 3 years ago

Test that all binaries are functional. E.g. that there are no issues with missing libraries or that some cmdline options are defined more than once. This just a draft, since some tools do not accept --version at the moment and fail even though they are ok.

lzaoral commented 2 years ago

All tools have been ported to llvm::cl so this PR is finally ready! The LLVM 13 failures will be fixed by #406.

lzaoral commented 2 years ago

Could you please revert the changes? I am quite sure that a lot of jobs will fail after you merged #408 before this.

Edit: #408 was marked as dependent on this PR.

lzaoral commented 2 years ago

Or leave it be, I'll try to fix the problems with command line parameters redefinitions tomorrow.

mchalupa commented 2 years ago

Oops, I thought I have re-run the CI, but apparently, I have not.

Edit: #408 was marked as dependent on this PR.

Sorry, I missed that.

lzaoral commented 2 years ago

No worries, I've already made a patch https://github.com/lzaoral/dg/commit/83a60a0293116d5672a9dd1324ea16b8083f8ae2 that makes the CI green: https://github.com/lzaoral/dg/actions/runs/1356570816 I'll make a PR with a polished version in the morning.

lzaoral commented 2 years ago

Oops, I thought I have re-run the CI, but apparently, I have not.

I think that you have but the CI configuration is always read from the source branch. Therefore, you need to do a rebase for it take effect.