search

mchalupa / dg

[LLVM Static Slicer] Various program analyses, construction of dependence graphs and program slicing of LLVM bitcode.
MIT License
474 stars 131 forks source link

Add missing SVF initialization step #414

Closed MrConnorKenway closed 2 years ago

MrConnorKenway commented 2 years ago

Commit c3f2db (https://github.com/SVF-tools/SVF/commit/c3f2db1a4f2d1ebfd57aab51d6eeb3ff0148d4b8) breaks the compatiability. The missing init step comes from https://github.com/SVF-tools/SVF/blob/25e04bd4e0180d11d36021e5b2eed466739ce2d0/tools/Example/svf-ex.cpp#L161.

mchalupa commented 2 years ago

Thanks for the contribution! This change is actually already included in the PR #412 by @lzaoral : https://github.com/mchalupa/dg/pull/412/commits/a0d0481c8c656db9716beab8ce7ed83c2ebc7f29. Merging this now would break that PR. @lzaoral , opinion?

lzaoral commented 2 years ago

@mchalupa I was actually thinking about splitting this change from my PR into a separate one so that dg at least would not crash with SVF until we fix the remaining issues described in https://github.com/mchalupa/dg/pull/412#issuecomment-949895322 and the following discussion. So feel free to merge this one instead.

mchalupa commented 2 years ago

@mchalupa I was actually thinking about splitting this change from my PR into a separate one so that dg at least would not crash with SVF until we fix the remaining issues described in #412 (comment) and the following discussion. So feel free to merge this one instead.

I guess the CI needs the commit https://github.com/mchalupa/dg/pull/412/commits/a963dc200a3d58a0cfb25c8c64fdcda30f3f3dce from #412, right?

lzaoral commented 2 years ago

Oh, I missed the CI failure. You're right. Shall we close this PR and I'll split mine into two?

mchalupa commented 2 years ago

Oh, I missed the CI failure. You're right. Shall we close this PR and I'll split mine into two?

Yes, we need to get https://github.com/mchalupa/dg/commit/a963dc200a3d58a0cfb25c8c64fdcda30f3f3dce into a new PR (or I can cherry-pick it manually if you do not feel like creating a new PR).

mchalupa commented 2 years ago

@MrConnorKenway thanks for this PR and sorry that it did not get through.