llvm-slicer.cpp fixes - Githubissues

lzaoral commented 2 years ago

Blocks: https://github.com/staticafi/sbt-slicer/pull/8

mchalupa commented 2 years ago

Will there be any new commits as this is still a draft?

lzaoral commented 2 years ago

Yes, at least the ones adding options mentioned in https://github.com/staticafi/sbt-slicer/pull/8#discussion_r877036939.

lzaoral commented 2 years ago

Unfortunately, I don't think it's that easy to remove the whole cutoffDivering code block without additional major changes due to the following lines: https://github.com/mchalupa/dg/blob/28f822ef5520f230060ce5b557e2c4d926ad76ec/tools/llvm-slicer.cpp#L201-L202

Function maybe_print_statistics is static. But that's just a minor issue as it could be easily moved to llvm-slicer-utils.cpp.
I'm not comfortable with calling writer inside of the slicer as these classes do different stuff and also, if we would call it from slicer, I can't think of any nice way to let the caller know, whether the slicing failed, whether it was successful or an empty main was created.

EDIT: If you have an idea, fell free to change the contents of this branch. I'm rather busy at the moment, so I don't know when I will have the time to look at it again.

lzaoral commented 1 year ago

I guess this can be marked as ready for review?

lzaoral commented 1 year ago

Nice, the macOS jobs are compiling again 💪🏻.

mchalupa / dg

llvm-slicer.cpp fixes #440