Closed barraIhsan closed 1 year ago
Do you just have the base neuter filter enabled? Or do you have any of the addons as well?
youtube.com
in the filter?
the commentbox exclusion works for the save as well as comment box for me
the edit still doesnt work. Tried with fresh firefox profile, still hides. The normal comment button works tho, but not the editing
https://github.com/mchangrh/yt-neuter/assets/57800056/c05b2b01-f29c-4c3b-8e97-ed50d8e27ce3
It's possible that ublock origin pulled an older version since the timestamp did not update - click on the eye icon and search for :not(.ytd-commentbox)
- I can't replicate locally
Maybe a firefox bug? also why the yellow part highlighted?
starting to sound like a firefox bug, will test on my install
wrong filter, it's the save button.
fixed in https://github.com/mchangrh/yt-neuter/commit/e5ea33cc828e20cc69863e61e0903ee9c1a513bf, verified with purge cache
nice! it works. Before, it seems is capturing both "Save" lmao
Edit: Now the save button that save the video into playlist appear again? It just blocked when the Save button is under the three dots
For the save button (not collapsed)
##ytd-button-renderer:has(>yt-button-shape:has(> button[aria-label="Save to playlist"]))
(the aria-label for save is not Save
, but Save to playlist
)
Save button on editing comment safe 👍
and for the save button that collapsed under ... (overflow)
##ytd-menu-service-item-renderer:has(>tp-yt-paper-item:has(>yt-formatted-string:has-text(Save)))
(to make it the same like the rest of the interaction row)
Again, "Save" button on editing comment safe
It appears the first filter of the interaction row has no use?
idk, not a good idea to remove this, probably just a issue on firefox, or this is for the old youtube layout
Some of these are for older versions, some are targeting overflows
ok, but the original problem is resolved, but the save button appear again (see the top of the comment), I think there is no need making new issue.
non-overflow save button removed in https://github.com/mchangrh/yt-neuter/commit/695b0f8c198306eb36a1a81bedcab53c85771226
ok
Bug
The bug is basically hide the "greyed out" Submit button on comment. And completely removed the Save button on comment editing.
With YouTube Neuter filter turned on:
Comment w/o content
Comment w/ content (expected behaviour)
Edit the comment w/ AND w/o content changed (the "Save" button just disappeared)
![image](https://github.com/mchangrh/yt-neuter/assets/57800056/014bcebe-8bd3-4e60-953d-771e5b1eb420)
With Youtube Neuter filter turned off:
Comment w/o content ("Submit" button should come up, but its grayed out)
Comment w/content (the same)
Edit the comment w/o content changed ("Save" greyed out)
Edit the comment w/ content changed (There is "Save" button)
![image](https://github.com/mchangrh/yt-neuter/assets/57800056/907b21d5-4c67-43df-90f4-fc739a101fd5)