search

mchangrh / yt-neuter

uBlock filter(s) list for blocking unwanted YouTube elements
https://neuter.mchang.xyz
The Unlicense
182 stars 13 forks source link

[Bug] Blocked "Save" Button on Youtube Comment #36

Closed barraIhsan closed 1 year ago

barraIhsan commented 1 year ago

Bug

The bug is basically hide the "greyed out" Submit button on comment. And completely removed the Save button on comment editing.

With YouTube Neuter filter turned on:

Comment w/o content image Comment w/ content (expected behaviour) image Edit the comment w/ AND w/o content changed (the "Save" button just disappeared) image

With Youtube Neuter filter turned off:

Comment w/o content ("Submit" button should come up, but its grayed out) image Comment w/content (the same) image Edit the comment w/o content changed ("Save" greyed out) image Edit the comment w/ content changed (There is "Save" button) image

mchangrh commented 1 year ago

Do you just have the base neuter filter enabled? Or do you have any of the addons as well?

mchangrh commented 1 year ago

found the offending lines https://github.com/mchangrh/yt-neuter/blob/2374e8c1a778adab6f070aa2060f47e8635dd6fa/yt-neuter.txt#L154-L155

barraIhsan commented 1 year ago
  1. The edit comment, still blocked the "Save" button (w/ and w/o change) image
  2. Did you just remove the youtube.com in the filter? image
mchangrh commented 1 year ago

the commentbox exclusion works for the save as well as comment box for me

barraIhsan commented 1 year ago

the edit still doesnt work. Tried with fresh firefox profile, still hides. The normal comment button works tho, but not the editing

https://github.com/mchangrh/yt-neuter/assets/57800056/c05b2b01-f29c-4c3b-8e97-ed50d8e27ce3

mchangrh commented 1 year ago

It's possible that ublock origin pulled an older version since the timestamp did not update - click on the eye icon and search for :not(.ytd-commentbox) - I can't replicate locally

barraIhsan commented 1 year ago

image Maybe a firefox bug? also why the yellow part highlighted?

mchangrh commented 1 year ago

starting to sound like a firefox bug, will test on my install

mchangrh commented 1 year ago

wrong filter, it's the save button.

mchangrh commented 1 year ago

fixed in https://github.com/mchangrh/yt-neuter/commit/e5ea33cc828e20cc69863e61e0903ee9c1a513bf, verified with purge cache

barraIhsan commented 1 year ago

nice! it works. Before, it seems is capturing both "Save" lmao image

Edit: Now the save button that save the video into playlist appear again? It just blocked when the Save button is under the three dots

barraIhsan commented 1 year ago

For the save button (not collapsed) ##ytd-button-renderer:has(>yt-button-shape:has(> button[aria-label="Save to playlist"])) (the aria-label for save is not Save, but Save to playlist) image Save button on editing comment safe 👍

and for the save button that collapsed under ... (overflow) ##ytd-menu-service-item-renderer:has(>tp-yt-paper-item:has(>yt-formatted-string:has-text(Save))) (to make it the same like the rest of the interaction row) image Again, "Save" button on editing comment safe

It appears the first filter of the interaction row has no use? image idk, not a good idea to remove this, probably just a issue on firefox, or this is for the old youtube layout

mchangrh commented 1 year ago

Some of these are for older versions, some are targeting overflows

barraIhsan commented 1 year ago

ok, but the original problem is resolved, but the save button appear again (see the top of the comment), I think there is no need making new issue.

mchangrh commented 1 year ago

non-overflow save button removed in https://github.com/mchangrh/yt-neuter/commit/695b0f8c198306eb36a1a81bedcab53c85771226

barraIhsan commented 1 year ago

ok