search

mchangrh / yt-neuter

uBlock filter(s) list for blocking unwanted YouTube elements
https://neuter.mchang.xyz
The Unlicense
182 stars 13 forks source link

yt-neuter hiding subscribe/unsubscribe button when activated #53

Closed vico93 closed 7 months ago

vico93 commented 8 months ago

I'm using this list on ublock origin, and when i activate it the subscribe/unsubscribe button dissapear from both channel and video pages. Deactivating it makes the button reappear.

With yt-neuter ON: image

With yt-neuter OFF: image

PasttaTypo commented 8 months ago

Yup, although it's only disappearing if you've subscribed to them.

youtube.com##yt-animated-action is the culprit in filter rules.

ZomoXYZ commented 8 months ago

youtube.com##yt-animated-action is the culprit in filter rules.

I can confirm this is the issue, commenting this line out after putting it all in My Filters allows me to see the Subscribed button

mchangrh commented 8 months ago

hiding the subscribe but not the unsubscribe button is intentional. The filter is

#@#subscribe-button

relevant commit https://github.com/mchangrh/yt-neuter/commit/3869c2650d0e58cca92e03b9538d9da73d6ab1c9

EpicLPer commented 8 months ago

hiding the subscribe but not the unsubscribe button is intentional. The filter is

#@#subscribe-button

relevant commit 3869c26

Not entirely sure why this should be intentional behavior, especially when it's hiding the button to unsubscribe when I'm already subscribed to a channel, which it currently does. image image

That said Subscriptions are a good thing, not a bad one. Plus hiding it would actually hurt the creator more than the end-user.

mchangrh commented 8 months ago

You need to reload to unhide elements after toggling uBo. I'll try to debug when I get home.

My mindset of neuter exists devoid of any creators - half of the elements in your screenshot are hidden by various filters. If the baby must be thrown out with the bathwater. Let it be so.

mchangrh commented 7 months ago

Turns out the culprit was https://github.com/mchangrh/yt-neuter/commit/eae39610f76ca63f14b437f4c6fbee9bc373b4cf. They moved the subscribe animation to be the parent of the subscribe element. This acted in the same way as https://github.com/mchangrh/yt-neuter/commit/3869c2650d0e58cca92e03b9538d9da73d6ab1c9, which was to unhide the unsubscribe button but hide the subscribe button. Now both are on the misc list, where the subscribe button being missing is expected.