search

mchardysam / python-binance-chain

Binance Chain Exchange API python implementation for automated trading
http://python-binance-chain.rtfd.io
MIT License
303 stars 132 forks source link

Conflicting dependencies issue #29

Closed cheeseandcereal closed 3 years ago

cheeseandcereal commented 5 years ago

This package requires the pip package pywallet, which in turn requires a package called two1.

This package has a very strict (and not to mention, unnecessary) set of requirement dependencies (see: https://github.com/21dotco/two1-python/blob/master/setup.py#L13) which causes dependency conflicts when installing this python-binance-chain package.

Considering that pywallet is literally only used to get a private key out of a seed via BIP32 standards, I would recommend using a lighter dependency, or at least a dependency that doesn't result in conflicts.

If you would agree @sammchardy (or anyone else who maintains this repository), I could probably put together a PR for this, I just don't want to do the work before I know you'd be willing to accept this change. Please let me know.

sammchardy commented 5 years ago

Hi @cheeseandcereal always happy to reduce dependency weight if you are able to.

cheeseandcereal commented 5 years ago

@sammchardy Implemented with pycoin instead.

If possible, it would be awesome if a release could be made after merging with these changes.

lobatt commented 4 years ago

Thanks @cheeseandcereal ! I had the same issue when trying to install this library.

@sammchardy it would be great if we can do a release since pip install python-binance-chain does not work right now.