search

mchbani / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

dynamically load libcurl in http_upload #225

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently we link to libcurl and use the functions directly in the Linux
http_upload code.  This is causing us a problem in Mozilla, as the libcurl
SOVERSION changed recently from 3 to 4, so our tinderbox builds are linking
to libcurl.so.3, but newer Linux distributions are shipping only
libcurl.so.4.  We should dynamically load libcurl so we can use
libcurl.so.4 or libcurl.so.3 depending on which exists.

Original issue reported on code.google.com by ted.mielczarek on 13 Nov 2007 at 6:41

GoogleCodeExporter commented 9 years ago

Original comment by ted.mielczarek on 13 Nov 2007 at 6:41

GoogleCodeExporter commented 9 years ago 
See https://bugzilla.mozilla.org/show_bug.cgi?id=392919 for details on the 
issues
we're having with Mozilla.

Original comment by ted.mielczarek on 13 Nov 2007 at 6:41

GoogleCodeExporter commented 9 years ago 
Here's the patch I attached to the Mozilla bug, merged to breakpad svn.

Original comment by ajsch...@verizon.net on 14 Nov 2007 at 5:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Update to review comments.

Note that libcurl.so will only exist as part of a development package and

minidump_upload and sym_upload don't actually compile due to passing the wrong 
number
of parameters to SendRequest

Original comment by ajsch...@verizon.net on 17 Nov 2007 at 5:59

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks!  That compile bustage is my fault, from issue 221, I'll clean that up 
and
check this in later.

Original comment by ted.mielczarek on 17 Nov 2007 at 7:20

GoogleCodeExporter commented 9 years ago 
Checked in in revision 232, I checked in the compile bustage separately right 
before
that.

Original comment by ted.mielczarek on 20 Nov 2007 at 2:36