search

mchck / programmer

SWD programmer
GNU General Public License v3.0
21 stars 11 forks source link

fix name mismatches in bitbang requests #10

Open floe opened 8 years ago

floe commented 8 years ago

I'm really not a Ruby expert, so perhaps there's a better way to fix the flush! issue (see second change in swd-bitbang.rb). But with these changes, everything works again for me with nRF51 & BusPirate.

Closes #9.

corecode commented 8 years ago

Thanks, I will have a look. I think the programmer code has reached its maximum level of managable complexity and probably needs a rewrite. Until then, let's keep it together with duct tape.

floe commented 8 years ago

Swapped :val and :count, makes more sense that way.

BTW, is there any specific reason it's written in Ruby? If a rewrite is planned anyway, maybe Python would be a more widespread option?

corecode commented 8 years ago

I am thinking of using a type safe language. Regarding popularity typescript or go seem to be reasonable options.

What do you think about those?

On March 18, 2016 12:58:41 PM GMT+01:00, Florian Echtler notifications@github.com wrote:

Swapped :val and :count, makes more sense that way.

BTW, is there any specific reason it's written in Ruby? If a rewrite is planned anyway, maybe Python would be a more widespread option?

You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/mchck/programmer/pull/10#issuecomment-198324055

Sent from my Android device with K-9 Mail. Please excuse my brevity.

floe commented 8 years ago

Hm, given those options, I'd prefer Go. More generally, I'd even suggest C++...

floe commented 8 years ago

Ah damn, if you swap :val and :count, that messes up transfer_block when called from write.

corecode commented 8 years ago

It's all a mess, especially without type safety :/ My own mess, but still a mess.