search

mchlmmc / CirnOS

Bringing the workflow of Arduino to the Raspberry Pi
GNU General Public License v3.0
101 stars 6 forks source link

Current Deploy.sh is Dangerous? #12

Open tilkinsc opened 5 years ago

tilkinsc commented 5 years ago

A hardcoded /dev/sdb1 is pretty eww as well as sudoing. You should make people sudo deploy.sh. Also, perhaps a unique name for the mounting folder. Maybe even a temporary.

mchlmmc commented 5 years ago

Good change to make. deploy.sh is just a simple utility for me to use, serving as a sort of template for other people that might want to develop. Now that CirnOS is gaining a bit of traction I should make a more generic and safe version.

Will do this sometime after my current demo and model 3 port.

tilkinsc commented 5 years ago

I'll be waiting for that model 3 port :)