mchlvl / starlette-zipkin

Zipkin client for asgi. Compatible with Starlette Framework and Jaeger tracing server
10 stars 5 forks source link

Cleanup tests to avoid coroutines of the BatchManager of aiozikin #31

Closed mardiros closed 2 years ago

mardiros commented 2 years ago

Currently tests are creating a BatchManager in many tests.

The test_trace module introduce a fixture to avoid it and tests expected trace to be send instead of pushing them in the batchmanager that cannot process them.

Here is a pull request to reuse the feature in other tests.

codecov-commenter commented 2 years ago

Codecov Report

Merging #31 (fe6f467) into master (e46e5ca) will decrease coverage by 1.39%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   88.15%   86.75%   -1.40%     
==========================================
  Files           8        8              
  Lines         287      287              
==========================================
- Hits          253      249       -4     
- Misses         34       38       +4     
Impacted Files Coverage Δ
starlette_zipkin/middleware.py 82.24% <100.00%> (-3.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e46e5ca...fe6f467. Read the comment docs.

mchlvl commented 2 years ago

Nice! 👍

mardiros commented 2 years ago

Sorry, I should let it as a draft. I will open a new merge request for the next improvement.