Closed mardiros closed 2 years ago
Merging #31 (fe6f467) into master (e46e5ca) will decrease coverage by
1.39%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 88.15% 86.75% -1.40%
==========================================
Files 8 8
Lines 287 287
==========================================
- Hits 253 249 -4
- Misses 34 38 +4
Impacted Files | Coverage Δ | |
---|---|---|
starlette_zipkin/middleware.py | 82.24% <100.00%> (-3.74%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e46e5ca...fe6f467. Read the comment docs.
Nice! 👍
Sorry, I should let it as a draft. I will open a new merge request for the next improvement.
Currently tests are creating a
BatchManager
in many tests.The test_trace module introduce a fixture to avoid it and tests expected trace to be send instead of pushing them in the batchmanager that cannot process them.
Here is a pull request to reuse the feature in other tests.