search

mchmarny / github-activity-counter

Cloud Run service for GitHub event Webhook to monitor repo or org activity in real-time in Stackdriver and analyze activity through ad-hoc SQL queries in BigQuery
Apache License 2.0
45 stars 2 forks source link

script moves on when errors #5

Open ahmetb opened 5 years ago

ahmetb commented 5 years ago

I think set -e is missing in the script.

e.g. ctrl+f "ERROR" below while executing bin/config

Enter a selection (1 - 15): 12

BigQuery configuration complete! Type "bq" to get started.

Dataset 'krew-k8s:eventcounter' successfully created.
Table 'krew-k8s:eventcounter.events' successfully created.
createTime: '2019-10-28T05:11:59.184968Z'
currentStateTime: '1970-01-01T00:00:00Z'
id: 2019-10-27_22_11_57-8922390344321487682
location: us-central1
name: eventcounter
projectId: krew-k8s
startTime: '2019-10-28T05:11:59.184968Z'
type: JOB_TYPE_STREAMING
Created service account [eventcounter-sa].
ERROR: (gcloud.beta.run.services.add-iam-policy-binding) NOT_FOUND: Resource 'eventcounter' of kind 'SERVICE' in region 'us-central1' in project 'krew-k8s' does not exist.
Updated IAM policy for project [krew-k8s].
bindings:
- members:
  - serviceAccount:434176090216@cloudbuild.gserviceaccount.com
  role: roles/cloudbuild.builds.builder
- members:
  - serviceAccount:service-434176090216@gcp-sa-cloudbuild.iam.gserviceaccount.com
ahmetb commented 5 years ago

I think readme is inaccurate a bit. bin/setup requires bin/service to be executed first.