mchobby / esp8266-upy

MicroPython Cross-platform Drivers - collection of code, wiring and sample for various breakout boards - Works with ESP8266, Pyboard, PYB405, Wemos, etc))
53 stars 30 forks source link

Fixed a typo in the BMP280 i2c addr constant (was BMP180) #1

Closed AlexDanault closed 6 years ago

AlexDanault commented 6 years ago

Was about to import this library and found this small typo, nothing critical but here's a PR.

BTW many thanks for this library !

AlexDanault commented 6 years ago

Je réalise que j'ai oublié le fichier readme.md, on y trouve du code qui à la constante en question.

mchobby commented 6 years ago

Hi Alex, Thank for the note. In fact, le I2C address of BMP180 and BMP280 are identical, the raison why I didn't modified it. As I have code using it, I will add your suggested content to avoids such misunderstanding Kind regards.

mchobby commented 6 years ago

Updated :-)

AlexDanault commented 6 years ago

Looks great ! Thanks !