search

mchome / flutter_advanced_networkimage

flutter advanced network image provider
https://pub.dev/packages/flutter_advanced_networkimage
MIT License
285 stars 180 forks source link

Disable memory cache for fallbackImage & fallbackAssetImage #67

Closed mchome closed 5 years ago

mchome commented 5 years ago

The fallback image should not be cached in flutter's ImageCache singleton.

mchome commented 5 years ago

It's hard to determining the fallback was used before pushing ImageStreamCompleter to ImageCache. So disableMemoryCache + useDiskCache is just a temporary solution.

davbaron commented 5 years ago

OK...I will try to use that for now. However, when I tried to use the new option (disableMemoryCache) it does not show up as an option in VS Code. I have tried:

flutter packages get flutter packages upgrade flutter update-packages flutter update-packages --force-upgrade

I have also tried shutting dow VS Code and restarting it... however nothing seems to 'pull in' the latest version. I can see the new code in git, so i know it's there...

Thank you again...

mchome commented 5 years ago

Sorry, i haven't put it into dart pub yet, because i want to know more details about https://github.com/mchome/flutter_advanced_networkimage/issues/68. You can try git version by this:

dependencies:
  flutter_advanced_networkimage:
    git:
      url: git://github.com/mchome/flutter_advanced_networkimage.git
      ref: fc36d88e80fc2a5628c0a69c19930535d1385cd1
davbaron commented 5 years ago

OK...no problem or rush... I just didn't know if it was something i was missing... I am going to try to build the example of #68 today.