mchorse / aperture

Advanced Minecraft camera mod
GNU General Public License v3.0
89 stars 17 forks source link

Use 2 commands to teleport player in servers, and add the ForgeUpdateCheck #13

Closed hedw1gP closed 6 years ago

hedw1gP commented 6 years ago

Reported by Ghost_chu

Since Essentials removed the native teleporting with real position in /tp (use /minecraft:tp instead).

mchorse commented 6 years ago

@ycwei982, would it be compatible with vanilla or Forge server, though? 🤔

hedw1gP commented 6 years ago

It should be working, because I remember there is a /give command which can let you use not only stone but also minecraft:stone...

mchorse commented 6 years ago

@ycwei982, it's different. Commands doesn't work that way. 😔

I think you should add a config option for essential servers, and then in that place if for the correct command.

mchorse commented 6 years ago

Is it still unfinished, or I can already merge? @ycwei982

Hm... Probably, but might it be that it changed four spaces to tab? 🤔

hedw1gP commented 6 years ago

Maybe... yes, because adding config options seemed to be like a hardcore job. If I finished, I will create another PR though.

Update: I am so glad that I did it! But there is still an issue, in the GUI Camera Options I cannot hide both Use /minecraft:tp and Use /tp in singleplayer, and I am using Minecraft.getMinecraft().isSingleplayer which you can see GuiConfigCameraOptions.java.

And the reason I replaced /tppos with /minecraft:tp is: /tppos doesn't seem to accept float position

hedw1gP commented 6 years ago

Just found why my Atom is so addicted to delete thousands of spaces and tabs. There is a Whitespaces package built-in. I gonna disable it and do some force push

mchorse commented 6 years ago

@ycwei982 another thing you could try is using mc.getCurrentServerData() as used in here, but it's weird that !isSingleplayer() triggers in singleplayer...

hedw1gP commented 6 years ago

All done! Thanks for your help 😄

mchorse commented 6 years ago

Great job, thanks! I'm gonna merge it 🙂 👌